fix(UptimeViewer): do not show StartTime if DisconnectTime present #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1858-uptime-popup
branch
from
079b067 to
e72c698
Compare
artemmufazalov
commented
Jan 22, 2025
Comment on lines
-33
to
-46
| content={ | ||
| <DefinitionList responsive> | ||
| {StartTime ? ( | ||
| <DefinitionList.Item key={'StartTime'} name={i18n('start-time')}> | ||
| {formatDateTime(StartTime, {withTimeZone: true})} | ||
| </DefinitionList.Item> | ||
| ) : null} | ||
| {DisconnectTime ? ( | ||
| <DefinitionList.Item key={'DisconnectTime'} name={i18n('disconnect-time')}> | ||
| {formatDateTime(DisconnectTime, {withTimeZone: true})} | ||
| </DefinitionList.Item> | ||
| ) : null} | ||
| </DefinitionList> | ||
| } |
There was a problem hiding this comment.
Previously I assumed, that if node is disconnected, there will be no StartTime in the response. However, StartTime may be cached somewhere on backend and we could receive both StartTime and DisconnectTime for disconnected node, in this case we have both values in the tooltip with different timestamps. After this fix StartTime will be in popover only if there is no DisconnectTime
Raubzeug
requested changes
Jan 22, 2025
| ) : null} | ||
| </DefinitionList> | ||
| } | ||
| content={<DefinitionList responsive>{content}</DefinitionList>} |
There was a problem hiding this comment.
let's add a case if content is null
There was a problem hiding this comment.
Disabled popup if no content
Raubzeug
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1858
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.06 MB | Main: 80.06 MB
Diff: 0.04 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information