Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SchemaTree): do not expand childless nodes #1868

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jan 22, 2025

Closes #1836

For ydb versions without ChildrenExist childless tree nodes will collapse when loaded (ydb-platform/ydb-ui-components#84).

Stand: https://nda.ya.ru/t/W_Ujns7r7BMTuJ

Before:

Screenshot 2025-01-22 at 18 21 47

After - nodes without children do not have chevrons:

Screenshot 2025-01-22 at 18 21 26

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
262 259 0 3 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 80.06 MB | Main: 80.06 MB
Diff: +0.68 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ae8aa6d Jan 22, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 1836-schema-tree-hide-childless branch January 22, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support ChildrenExist prop in schema tree
2 participants