fix(FormattedBytes): show 1_000 with another unit #1901
Conversation
| @@ -11,5 +11,5 @@ export const toFormattedSize = ( | |||
| return null; | |||
| } | |||
|
|
|||
| return <FormattedBytes value={value} significantDigits={2} {...params} />; | |||
| return <FormattedBytes value={value} {...params} />; | |||
There was a problem hiding this comment.
It seems we don't use significantDigits param any more. What do you think about remove it completely? It seems it will simplify logic for formatting values a lot.
artemmufazalov
force-pushed
the
1455-tables-size
branch
from
c3a264d to
f37941a
Compare
| const result1 = formatNumericValues(10, 20); | ||
| expect(result1).toEqual(['10', `20`]); |
There was a problem hiding this comment.
Before in such case formatNumericValues returned ['0', '0']
| let size: Digits = 'thousand'; | ||
|
|
||
| if (value > thousandLevel) { | ||
| export const getNumberSizeUnit = (value: number) => { |
There was a problem hiding this comment.
May we use http://numeraljs.com/ instead of custom unit getter?
There was a problem hiding this comment.
We use custom getter, because together with auto formatting we can pass specific unit - it's helpful for data inside tables (data on every row should be with the same unit). AFAIK numeral cannot do formatting to specific units. While formatNumber is not widely used, formatBytes with the same approach is used in most of the tables
Closes #1455
Before:
After:
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.19 MB | Main: 80.20 MB
Diff: 2.37 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information