Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compaction sequentially in case huge memory usage #13668

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Compaction sequentially in case huge memory usage #13668

merged 6 commits into from
Jan 22, 2025

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 14:53:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3d73746 has started.
⚪ 2025-01-21 14:53:55 UTC Artifacts will be uploaded here
⚪ 2025-01-21 14:57:06 UTC ya make is running...
⚫ 2025-01-21 15:25:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 14:54:13 UTC Pre-commit check linux-x86_64-release-asan for 3d73746 has started.
⚪ 2025-01-21 14:54:19 UTC Artifacts will be uploaded here
⚪ 2025-01-21 14:57:32 UTC ya make is running...
⚫ 2025-01-21 15:25:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:27:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for aacd34e has started.
⚪ 2025-01-21 15:27:42 UTC Artifacts will be uploaded here
⚪ 2025-01-21 15:30:54 UTC ya make is running...
🟡 2025-01-21 16:31:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27623 25109 0 6 2380 128

⚪ 2025-01-21 16:34:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-21 16:46:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 75 0 1 0 118

⚪ 2025-01-21 16:46:44 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-21 16:59:05 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 54 0 1 0 118

🟢 2025-01-21 16:59:13 UTC Build successful.
🟡 2025-01-21 16:59:36 UTC ydbd size 2.1 GiB changed* by +124.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 440c81e merge: aacd34e diff diff %
ydbd size 2 216 956 600 Bytes 2 217 083 808 Bytes +124.2 KiB +0.006%
ydbd stripped size 468 691 280 Bytes 468 712 560 Bytes +20.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:29:47 UTC Pre-commit check linux-x86_64-release-asan for aacd34e has started.
⚪ 2025-01-21 15:30:00 UTC Artifacts will be uploaded here
⚪ 2025-01-21 15:33:12 UTC ya make is running...
🟡 2025-01-21 16:38:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13306 13207 0 31 40 28

⚪ 2025-01-21 16:39:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-21 16:50:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 83 0 8 20 24

⚪ 2025-01-21 16:50:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-21 17:02:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77 (only retried tests) 48 0 5 1 23

🟢 2025-01-21 17:02:46 UTC Build successful.
🟡 2025-01-21 17:03:16 UTC ydbd size 3.6 GiB changed* by +222.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 440c81e merge: aacd34e diff diff %
ydbd size 3 853 560 184 Bytes 3 853 787 720 Bytes +222.2 KiB +0.006%
ydbd stripped size 1 346 385 168 Bytes 1 346 448 848 Bytes +62.2 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 06:03:29 UTC Pre-commit check linux-x86_64-release-asan for 09717eb has started.
⚪ 2025-01-22 06:03:42 UTC Artifacts will be uploaded here
⚪ 2025-01-22 06:08:34 UTC ya make is running...
🔴 2025-01-22 06:36:22 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 06:03:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 09717eb has started.
⚪ 2025-01-22 06:03:46 UTC Artifacts will be uploaded here
⚪ 2025-01-22 06:08:28 UTC ya make is running...
🔴 2025-01-22 06:35:56 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 06:47:58 UTC Pre-commit check linux-x86_64-release-asan for 3761b80 has started.
⚪ 2025-01-22 06:48:04 UTC Artifacts will be uploaded here
⚪ 2025-01-22 06:51:25 UTC ya make is running...
⚫ 2025-01-22 06:56:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 06:51:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3761b80 has started.
⚪ 2025-01-22 06:51:18 UTC Artifacts will be uploaded here
⚪ 2025-01-22 06:54:33 UTC ya make is running...
⚫ 2025-01-22 06:56:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 07:00:28 UTC Pre-commit check linux-x86_64-release-asan for 1c5b20a has started.
⚪ 2025-01-22 07:00:40 UTC Artifacts will be uploaded here
⚪ 2025-01-22 07:03:55 UTC ya make is running...
🔴 2025-01-22 07:14:30 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 07:00:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1c5b20a has started.
⚪ 2025-01-22 07:00:47 UTC Artifacts will be uploaded here
⚪ 2025-01-22 07:04:00 UTC ya make is running...
🔴 2025-01-22 07:12:54 UTC Build failed, see the logs. Also see fail summary

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jan 22, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 22, 2025
@ivanmorozov333 ivanmorozov333 force-pushed the compaction_sequentially_in_case_huge_memory_usage branch from ef4bca3 to c458b6f Compare January 22, 2025 07:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 07:28:52 UTC Pre-commit check linux-x86_64-release-asan for ff46a5c has started.
⚫ 2025-01-22 07:29:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 07:30:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 538c385 has started.
⚪ 2025-01-22 07:30:51 UTC Artifacts will be uploaded here
⚪ 2025-01-22 07:34:20 UTC ya make is running...
🔴 2025-01-22 07:40:18 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 07:31:20 UTC Pre-commit check linux-x86_64-release-asan for 538c385 has started.
⚪ 2025-01-22 07:31:25 UTC Artifacts will be uploaded here
⚪ 2025-01-22 07:34:38 UTC ya make is running...
🔴 2025-01-22 07:41:46 UTC Build failed, see the logs. Also see fail summary

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jan 22, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 09:09:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e96b41 has started.
⚪ 2025-01-22 09:10:07 UTC Artifacts will be uploaded here
⚪ 2025-01-22 09:13:31 UTC ya make is running...
⚫ 2025-01-22 09:28:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 09:09:57 UTC Pre-commit check linux-x86_64-release-asan for 6e96b41 has started.
⚪ 2025-01-22 09:10:09 UTC Artifacts will be uploaded here
⚪ 2025-01-22 09:13:35 UTC ya make is running...
⚫ 2025-01-22 09:29:00 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the compaction_sequentially_in_case_huge_memory_usage branch from 4b36cf6 to f1435c8 Compare January 22, 2025 09:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 09:37:10 UTC Pre-commit check linux-x86_64-release-asan for a57fb71 has started.
⚪ 2025-01-22 09:37:22 UTC Artifacts will be uploaded here
⚪ 2025-01-22 09:40:50 UTC ya make is running...
🟡 2025-01-22 10:43:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13165 13079 0 36 22 28

⚪ 2025-01-22 10:44:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 10:56:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 90 0 8 8 24

⚪ 2025-01-22 10:56:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-22 11:08:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 33 0 6 1 24

🟢 2025-01-22 11:08:40 UTC Build successful.
🟡 2025-01-22 11:09:10 UTC ydbd size 3.6 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d8ea merge: a57fb71 diff diff %
ydbd size 3 854 926 792 Bytes 3 856 349 000 Bytes +1.4 MiB +0.037%
ydbd stripped size 1 346 948 912 Bytes 1 348 685 712 Bytes +1.7 MiB +0.129%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 09:37:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for a57fb71 has started.
⚪ 2025-01-22 09:37:26 UTC Artifacts will be uploaded here
⚪ 2025-01-22 09:40:40 UTC ya make is running...
🟡 2025-01-22 10:33:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27526 25000 0 3 2399 124

⚪ 2025-01-22 10:36:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-22 10:47:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 72 0 0 0 117

🟢 2025-01-22 10:47:47 UTC Build successful.
🟡 2025-01-22 10:48:06 UTC ydbd size 2.1 GiB changed* by +1.8 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f64d8ea merge: a57fb71 diff diff %
ydbd size 2 217 672 912 Bytes 2 219 602 336 Bytes +1.8 MiB +0.087%
ydbd stripped size 468 946 000 Bytes 469 492 880 Bytes +534.1 KiB +0.117%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review January 22, 2025 11:21
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner January 22, 2025 11:21
@ivanmorozov333 ivanmorozov333 merged commit 362d8a2 into ydb-platform:main Jan 22, 2025
12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the compaction_sequentially_in_case_huge_memory_usage branch January 22, 2025 16:32
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 29, 2025
@ivanmorozov333 @zverevgeny
Compaction sequentially in case huge memory usage (ydb-platform#13668)
dc7d980 
Conflicts:
	ydb/core/protos/config.proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalrus1 swalrus1 swalrus1 approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @swalrus1