Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Kong #374 #390

Closed
wants to merge 9 commits into from
Closed

add Kong #374 #390

wants to merge 9 commits into from

Conversation

rossgalloway
Copy link
Collaborator

Pull request to add kong information as requested in #374

  • added information about Kong to line 89 in hacking-with-yearn.md. removed repeat information from that section.
  • updated hacking-with-yearn.md to match style guide. Let me know if you want these changes reverted. Markdown Lint plugin made most of them automatically, and I adjusted the heading types to match the style guide.
  • added kong to links under the statistics section of links.md.

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearn-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 10:32pm

MarcoWorms
MarcoWorms reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@MarcoWorms MarcoWorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR, just a smol suggestion, tyvm!

docs/developers/v2/hacking-with-yearn.md Outdated Show resolved Hide resolved
@MarcoWorms
Copy link
Collaborator

many of the dead links are trully dead, maybe just remove all that are really dead (need to open 1 by one because bot has some false positives)

rossgalloway and others added 2 commits December 14, 2023 17:29
@rossgalloway
- add kong info to 'front-end Integrations'
136112a 
- adjust hacking-with-yearn.md to match style guide
- add kong to links
@rossgalloway @MarcoWorms
Update docs/developers/v2/hacking-with-yearn.md
8aa53b0 
Co-authored-by: Marco Guaspari Worms <[email protected]>
@MarcoWorms
Copy link
Collaborator

relevant comment: #374 (comment)

@0xBasically
Copy link
Contributor

Kong is too experimental too add at this stage, Feel free to re-ping if they add more features

@rossgalloway rossgalloway deleted the add-kong-#374 branch April 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoWorms MarcoWorms MarcoWorms left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossgalloway @MarcoWorms @0xBasically