Fix image file cleanup (#119)

fix(writer/standard): closed open file descriptor in in writer option and test cases * Option: close image files after use * TestCases: close open files from tests
yeqown · Dec 5, 2024 · 4bcbcb5 · 4bcbcb5
1 parent e166367
commit 4bcbcb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/writer/standard/image_option_api.go b/writer/standard/image_option_api.go
@@ -94,6 +94,7 @@ func WithLogoImageFileJPEG(f string) ImageOption {
 			fmt.Printf("could not open file(%s), error=%v\n", f, err)
 			return
 		}
+		defer fd.Close()
 
 		img, err := jpeg.Decode(fd)
 		if err != nil {
@@ -114,6 +115,7 @@ func WithLogoImageFilePNG(f string) ImageOption {
 			fmt.Printf("Open file(%s) failed: %v\n", f, err)
 			return
 		}
+		defer fd.Close()
 
 		img, err := png.Decode(fd)
 		if err != nil {

diff --git a/writer/standard/writer_test.go b/writer/standard/writer_test.go
@@ -124,6 +124,8 @@ func hashFile(filename string) (string, error) {
 	if err != nil {
 		return "", err
 	}
+	defer fd1.Close()
+
 	bytes, err := io.ReadAll(fd1)
 	if err != nil {
 		return "", err
@@ -140,6 +142,7 @@ func statImage(filename string) (w, h int, err error) {
 	if err != nil {
 		return 0, 0, err
 	}
+	defer fd.Close()
 
 	img, err := png.Decode(fd)
 	if err != nil {