Don't preemptively spill values. #1641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We once needed this hack when:
1. our register allocator was more rubbish than it is today;
2. we didn't have side traces (or, soon to come, bridge/link traces).
The situation now is a bit different:
a. Preemptively spilling (I think...) doesn't meaningfully help the
register allocator (or, if it does, that's something I should fix).
b. For side traces, we end up unspilling everything we spill, even if
there were spare registers we could have kept values in.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
one more for luck |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This probably hits a bigger bug I'm working on. I'm going to close it, because it's probably best tackled as part of that wider effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We once needed this hack when:
The situation now is a bit different:
a. Preemptively spilling (I think...) doesn't meaningfully help the
register allocator (or, if it does, that's something I should fix). b. For side traces, we end up unspilling everything we spill, even if there were spare registers we could have kept values in.