Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define WebActions #1

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 28, 2024

Description

Applications addon does define web actions and adds new launch argument.

Additional information

This PR requires

This approach has few caveats. We always expected that launch of application happens from tray application where is possible to log into ftrack, kitsu etc. but with this approach they don't have option to login, we have to resolve that issue before full production.

Testing notes

  1. Make sure you have all requirements mentioned above.
  2. Create package of applications addon.
  3. Upload pacakge to server (upload is required).
  4. Use it in a bundle.
  5. If is used in developer bundle then make sure Develop mode is enabled and for production make sure Develop mode is disabled.
  6. Select a task.
  7. Applications actions should show up.
  8. Launch any.

This PR might be split into 2 PRs, it does contain logic related to webactions and related to process preparation ynput/ayon-core#781 . They cannot be tested as separate PRs.

@fabiaserra
Copy link

Commented on ynput/ayon-launcher#112 (comment)

@fabiaserra
Copy link

It's working great for me, I only encountered that blocker from my last comment and it also broke our CI/CD pipeline to upload addons to the server due to:

Traceback (most recent call last):
  File "__startup__.py", line 120, in run
  File "console.py", line 16, in run
  File "start.py", line 981, in <module>
  File "start.py", line 971, in main
  File "start.py", line 671, in boot
  File "start.py", line 657, in init_launcher_executable
  File "/pipe/ayon/release/current/common/ayon_common/utils.py", line 940, in deploy_ayon_launcher_shims
    _deploy_shim_linux(installer_shim_root)
  File "/pipe/ayon/release/current/common/ayon_common/utils.py", line [83](https://gitlab.alkemy-x.com/coreweave/pipeline/ayon/ayon-applications/-/jobs/70541#L83)9, in _deploy_shim_linux
    with open(dst_desktop_executable, "r") as stream:
NotADirectoryError: [Errno 20] Not a directory: '/root/.local/share/applications/ayon.desktop'
Extracting /pipe/ayon/release/current/shim/shim.tar.gz -> /root/.local/share/AYON/shim

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Aug 29, 2024

It's working great for me, I only encountered that blocker from my last comment and it also broke our CI/CD pipeline to upload addons to the server due to:

Not related to this PR. And sorry, because we won't change it. Any comments related to this please move to ayon-launcher. Creating fix PR in ayon-launcher.

@mkolar mkolar changed the title WebActions: Defines WebActions Define WebActions Sep 5, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on Windows

@64qam
Copy link
Member

64qam commented Sep 6, 2024

Doesn't work on linux. Applications show up, but even launcher doesn't start:-(

@64qam 64qam self-requested a review September 6, 2024 07:28
@iLLiCiTiT
Copy link
Member Author

Doesn't work on linux. Applications show up, but even launcher doesn't start:-(

Resolved, it was on linux that was used for testing of previous versions and had shim variant from development phase.

@iLLiCiTiT iLLiCiTiT merged commit abd4bce into develop Sep 6, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-5949_Applications-addon-defines-webactions branch September 6, 2024 09:12
@iLLiCiTiT iLLiCiTiT added the type: feature Adding something new and exciting to the product label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants