-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define WebActions #1
Define WebActions #1
Conversation
Commented on ynput/ayon-launcher#112 (comment) |
It's working great for me, I only encountered that blocker from my last comment and it also broke our CI/CD pipeline to upload addons to the server due to: Traceback (most recent call last):
File "__startup__.py", line 120, in run
File "console.py", line 16, in run
File "start.py", line 981, in <module>
File "start.py", line 971, in main
File "start.py", line 671, in boot
File "start.py", line 657, in init_launcher_executable
File "/pipe/ayon/release/current/common/ayon_common/utils.py", line 940, in deploy_ayon_launcher_shims
_deploy_shim_linux(installer_shim_root)
File "/pipe/ayon/release/current/common/ayon_common/utils.py", line [83](https://gitlab.alkemy-x.com/coreweave/pipeline/ayon/ayon-applications/-/jobs/70541#L83)9, in _deploy_shim_linux
with open(dst_desktop_executable, "r") as stream:
NotADirectoryError: [Errno 20] Not a directory: '/root/.local/share/applications/ayon.desktop'
Extracting /pipe/ayon/release/current/shim/shim.tar.gz -> /root/.local/share/AYON/shim |
Not related to this PR. |
…s-webactions # Conflicts: # client/ayon_applications/addon.py # client/ayon_applications/defs.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on Windows
Doesn't work on linux. Applications show up, but even launcher doesn't start:-( |
Resolved, it was on linux that was used for testing of previous versions and had shim variant from development phase. |
Description
Applications addon does define web actions and adds new launch argument.
Additional information
This PR requires
This approach has few caveats. We always expected that launch of application happens from tray application where is possible to log into ftrack, kitsu etc. but with this approach they don't have option to login, we have to resolve that issue before full production.
Testing notes
This PR might be split into 2 PRs, it does contain logic related to webactions and related to process preparation ynput/ayon-core#781 .They cannot be tested as separate PRs.