Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmony: Update env var to the new key name in recent ayon-harmony #13

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Harmony: Update env var to the new key name in recent ayon-harmony #13

merged 1 commit into from
Jul 30, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 30, 2024

Changelog Description

Change AVALON_HARMONY_WORKFILES_ON_LAUNCH -> AYON_HARMONY_WORKFILES_ON_LAUNCH

Additional info

See:

Testing notes:

  1. Defaults should be updated
  2. Defaults should make sense with latest release of harmony.

@BigRoy BigRoy added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Jul 30, 2024
@BigRoy BigRoy requested review from iLLiCiTiT and LiborBatek July 30, 2024 21:33
@BigRoy BigRoy self-assigned this Jul 30, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 30, 2024 •
edited
Loading

It's a bit unclear from here whether this works out of the box now.

Nevermind, seems to have been confirmed that it does work

iLLiCiTiT
iLLiCiTiT approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but question is why is this defined by environment variable and not setting?

@iLLiCiTiT iLLiCiTiT merged commit 1f635c6 into ynput:develop Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@BigRoy BigRoy

Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigRoy @iLLiCiTiT