Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Application variants in default settings #24

Merged
merged 19 commits into from
Sep 10, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Removed old variants and added more recent releases.

Testing notes:

  1. Validate added variants.
  2. Make sure the defaults are actually working.

Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, we still get plenty of users using Maya 2022 (which is Py3) so I'd personally keep that one in for the time being.

@m-u-r-p-h-y
Copy link
Member

m-u-r-p-h-y commented Sep 6, 2024

How difficult would it be to eliminate the inconsistency in the naming of apps in Application addon settings?

Autodesk <APP>
Adobe <APP>

and rest is just simple:
Nuke, Blender, Resolve, Houdini, etc.

I suppose it is only a label so it should not affect apps in anatomy templates in any way . . .
image

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Sep 6, 2024

You simply should update to this PR (or develop)
image

@m-u-r-p-h-y
Copy link
Member

m-u-r-p-h-y commented Sep 6, 2024

You simply should update to this PR (or develop)

I copied the applications.json to my server, restarted and reset to defaults to test . . .

@iLLiCiTiT
Copy link
Member Author

I copied the applications.json to my server, restarted and reset to defaults to test . . .

Labels are not defined in applications.json .

@MustafaJafar
Copy link
Contributor

However, we still get plenty of users using Maya 2022 (which is Py3) so I'd personally keep that one in for the time being.

It's also worth mentioning that Maya 2022 may not be compatible with some addons.
like this issue in kitsu: https://community.ynput.io/t/i-get-an-error-when-i-use-mayas-ayon-publishing-tool-how-can-i-fix-it/1677

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the default executables.
Could it also update/remove deprecated environment variables ?
e.g.

"environment": "{\n \"NUKE_PATH\": [\n \"{NUKE_PATH}\",\n \"{OPENPYPE_STUDIO_PLUGINS}/nuke\"\n ]\n}",

@iLLiCiTiT
Copy link
Member Author

However, we still get plenty of users using Maya 2022 (which is Py3) so I'd personally keep that one in for the time being.

Is that reason to have it in defaults? You can still add it if you need it.

@BigRoy
Copy link
Contributor

BigRoy commented Sep 9, 2024

Is that reason to have it in defaults? You can still add it if you need it.

I'd say if many clients are using it then - yes, it's a valid default. But happy to stand corrected by @m-u-r-p-h-y or @LiborBatek

@LiborBatek
Copy link
Member

@BigRoy I think removing maya 2022 should be the way imho ...as been said "can be added manually"

I guess this maya version is no longer fully supported by default, or rather not the one users should stick to (by default)? I could be wrong tho...

@iLLiCiTiT iLLiCiTiT merged commit 476ea15 into develop Sep 10, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/update-settings branch September 10, 2024 07:41
@iLLiCiTiT iLLiCiTiT added the type: feature Adding something new and exciting to the product label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants