Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use variant name if label is not filled #32

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Use variant name if label is not filled #32

merged 4 commits into from
Sep 19, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Don't require label filled on application and tool variant.

Additional info

Also removed labels that are same as name.

Testing notes:

  1. Create package, upload to server and add to your bundle.
  2. Go to settings, remove application or tool variant label and save settings.
  3. Both applications and tools selection combobox should use variant name as variant label.

Resolves #28

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Sep 19, 2024
@iLLiCiTiT iLLiCiTiT merged commit cf87297 into develop Sep 19, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/28-ay-6766_if-label-is-empty-we-shoud-use-name branch September 19, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@MilaKudr MilaKudr

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AY-6766_if Label is empty we shoud use Name
3 participants
@iLLiCiTiT @64qam @MilaKudr