Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Gaffer support #49

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Adds Gaffer support #49

wants to merge 2 commits into from

Conversation

sosoyan
Copy link

@sosoyan sosoyan commented Jan 15, 2025

Changelog Description

Added support for Gaffer and should work with ayon-gaffer addon
https://github.com/RVXStudio/ayon-gaffer

Additional review information

https://github.com/GafferHQ/gaffer

Testing notes:

  1. Add a path to your gaffer executable in Application Settings
  2. Run as any other application from Launcher

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Jan 16, 2025
server/applications.json Outdated Show resolved Hide resolved
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I think it'd be nice to add default paths for windows and linux as pointed out in my comment because it'd aid admins to know what to point to.

Other than that, this is indeed what is needed to add gaffer app support.

Might be nice in the PR description to point to a matching ayon-gaffer integration addon repository that may work with this PR - just so it's tracked here for the future.

E.g. I know of https://github.com/RVXStudio/ayon-gaffer

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.
Because there's no addon for it I think AYON will only launch it.
image

@sosoyan
Copy link
Author

sosoyan commented Jan 16, 2025

It works. Because there's no addon for it I think AYON will only launch it. image

I'm working on minimal ayon-gaffer addon will pr when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants