Icons statics: Don't use version in local webserver path #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
requested review from
BigRoy,
kalisp,
64qam,
antirotor and
jakubjezek001
|
I'm not sure how to best test this and what it may effect potentially. |
There is no much to test. You should not see any difference... |
64qam
approved these changes
Jul 31, 2024
iLLiCiTiT
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't use addon version when supplying statics on localhost.
Additional information
To be able to use the uri one has to know which addon version is used, which is not really necessary for localhost, which has to run in tray, which can use only one version of an addon at a time.