Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AYON context to the AYON menu #12

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Oct 8, 2024

Changelog Description

resolve #11

image

Animation_47

Testing notes:

  1. Launch c4d via AYON Launcher
  2. Check if AYON context is shown properly.

@MustafaJafar MustafaJafar added the type: enhancement Improvement of existing functionality or minor addition label Oct 8, 2024
@MustafaJafar MustafaJafar requested a review from BigRoy October 8, 2024 12:47
@MustafaJafar MustafaJafar self-assigned this Oct 8, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Oct 8, 2024

I'm quite confident that this will not update the label on folder/task changes - it's not live but the menu is built one. We'd need a dynamic menu label otherwise (not sure how to do that).

Which means the label that would be displayed would not be accurate.


Here's a younger me on how to define a custom menu for Cinema4D: https://developers.maxon.net/forum/topic/12103/custom-menu-in-c4d-top-menu-bar-with-custom-python-commands

This http://developers.maxon.net/forum//post/70228 seems to describe there is some way to update menus later. But I'm not sure how/where exactly.

@MustafaJafar
Copy link
Contributor Author

I was able to test this PR.
The context label doesn't even appear.
image

@MustafaJafar
Copy link
Contributor Author

Now, the AYON context is shown BUT as @BigRoy mentioned above, it's static and not updated on context change.

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notes - other than that this looks good!

@@ -60,6 +64,8 @@ AYON_RESET_RESOLUTION_ID = 1064318
AYON_RESET_COLORSPACE_ID = 1064320
AYON_EXPERIMENTAL_TOOLS_ID = 1064319

AYON_CONTEXT_LABEL = 1064309
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you base this number on @MustafaJafar - is this officially registered with Maxon?

Copy link
Contributor Author

@MustafaJafar MustafaJafar Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't know.

I assume these are unique numbers to register the plugins/commands. I picked the smallest number - 1 in the pyp file.

client/ayon_cinema4d/startup/ayon_cinema4d.pyp Outdated Show resolved Hide resolved
@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Dec 9, 2024

In my last commit, I've added AYON icon. Please let me know if you don't like it :) @BigRoy

image

@MustafaJafar MustafaJafar requested a review from BigRoy December 9, 2024 10:55
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much - looking very nice!

@MustafaJafar MustafaJafar merged commit 4ef6822 into develop Dec 9, 2024
1 check passed
@MustafaJafar MustafaJafar deleted the 11-show-ayon-context-in-ayon-menu branch December 9, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show AYON context in AYON Menu
2 participants