Add BorisFX Silhouette support #1070
Open
+9
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `TreeViewSpinner` widget was not used anywhere - The `QtSvg` dependency does not exist in BorisFX Silhouette so removing it was easiest to make Silhouette not error on this import
ynbot
added
size/XS
type: enhancement
31 tasks
…e Silhouette projects are actually folders (with .sfx extension)
…github.com/BigRoy/ayon-core into enhancement/add_borisfx_silhouette_support
BigRoy
commented
Jan 8, 2025
iLLiCiTiT
reviewed
Jan 8, 2025
| @@ -19,48 +18,6 @@ def mousePressEvent(self, event): | |||
| QtWidgets.QTreeView.mousePressEvent(self, event) | |||
|
|
|||
|
|
|||
| class TreeViewSpinner(QtWidgets.QTreeView): | |||
There was a problem hiding this comment.
We could - but seems messy? :) Or did you mean to then remove it in a separate PR?
There was a problem hiding this comment.
It is messy, but at least some reminder that we actually did have refresh animations (and that we should put them back)...
There was a problem hiding this comment.
I think we're better off maybe creating an issue if we want to keep track of that - it could e.g. link to the removal commit. What you think?
|
Note that this is also needed for Mocha Pro, same issue there. |
5 tasks
…' into enhancement/add_borisfx_silhouette_support
- This change was also tested in Fusion (where Qt runs completely separately and this addition didn't result in a visual difference there)
|
Note: This PR now also contains #1070 because it kept getting in the way when testing Silhouette integration. |
iLLiCiTiT
reviewed
Jan 20, 2025
iLLiCiTiT
reviewed
Jan 20, 2025
Co-authored-by: Jakub Trllo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Initial changes to support BorisFX Silhouette
Additional info
To be used together with:
I had to remove the
TreeViewSpinnerwidget in our codebase: Remove TreeViewSpinner with QtSvg dependencyTreeViewSpinnerwidget was not used anywhereQtSvgdependency does not exist in BorisFX Silhouette so removing it was easiest to make Silhouette not error on this importTesting notes: