Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create: Auto-fill project entity in get product name if is not passed in #1103

Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Auto fill project entity from current context if is not passed into the create plugin method.

Additional info

There is low chance we will call this method from different than current project, but I've added check for the project name (just safety).

Testing notes:

  1. Product name calculation might be a little bit faster for creators which are calling the method on their own (e.g. auto-creators).

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 24, 2025
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Jan 24, 2025
@ynbot ynbot added the size/XS label Jan 24, 2025
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Didn't test but should be fine.

@iLLiCiTiT iLLiCiTiT merged commit 365ac46 into develop Feb 4, 2025
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/fill-project-name-in-get-product-name branch February 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants