Settings: Change settings attributes in submit publish job plugin #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLLiCiTiT
changed the title
iLLiCiTiT
added
the
type: enhancement
64qam
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Change order of attributes in submit publish job plugins to match order in CollectJobInfo settings.
Additional review information
Different order of attributes lead to wrong assignment of values (pool <-> group) and I agree that the order should follow same order. Because I think the order in CollectJobInfo makes more sense I've changed submit publish job accordingly.
Testing notes:
Technically nothing changed, only settings UI shows attributes in different order.