Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to publish instances if they are disabled #18

Closed
wants to merge 2 commits into from
Closed

No need to publish instances if they are disabled #18

wants to merge 2 commits into from

Conversation

jakubjezek001
Copy link
Member

Publishing instances does not need to be created if they are disabled

Test steps:

  • disable node in Node view which is also publishing instance
  • hit collect publishing instances and see that instance is not collected.

@jakubjezek001
Add node enable checks for rendering instances
2feeaa3 
- Added logic to check if nodes are enabled before processing.
- Skipped disabled nodes in both the collect render and collect instances functionalities.
- Updated instance data to reflect the enabled status correctly.
@jakubjezek001
Remove unnecessary log statement
ad08425 
Cleaned up the logging by removing an info message that wasn't needed. This helps streamline the server's output and keeps logs more relevant.
@jakubjezek001 jakubjezek001 self-assigned this Dec 20, 2024
@jakubjezek001 jakubjezek001 requested a review from kalisp December 20, 2024 15:22
@jakubjezek001 jakubjezek001 added the type: bug Something isn't working label Dec 20, 2024
kalisp
kalisp approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and work.

Will probably need to pushed from Node to Instance when available in Publisher (or other way).

@BigRoy
Copy link
Contributor

BigRoy commented Dec 24, 2024

This is also solved in #17

Will probably need to pushed from Node to Instance when available in Publisher (or other way).

Also implemented in #17

@jakubjezek001
Copy link
Member Author

no need to merge it if it is part of planned update via #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubjezek001 @BigRoy @kalisp