Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto connect to composition node #23

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jan 13, 2025

Changelog Description

Supports automatically connecting newly created Write node to existing Composition mode. This is mostly useful for artists with Harmony Advanced where no Node View is available (and that way Use selection will not work).
Unconnected write node results in blank/black frames.

Added Settings to control this in more detail, provides regex pattern to select Composite node more precisely.

Testing notes:

  1. enable Auto connect to node
    image

  2. experiment with disabling Use selected and unselecting composition

  3. create multiple Composite node with unmatching names to

auto_connect allows customers with Harmony Advanced to create write nodes automatically connected to Composition as `Use selected` will not work and there is no Node View.
auto_connect allows customers with Harmony Advanced to create write nodes automatically connected to Composition as `Use selected` will not work and there is no Node View.
Was throwing argument error
Previous package was already deployed on customer site, no full release since.
@kalisp kalisp added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Jan 13, 2025
@kalisp kalisp self-assigned this Jan 13, 2025
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as advertised if the settings default are changed

…osition-node-and-connect-automatically-if-not-Use-selection
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but tested on Pro

…enhancement/AY-7307_Harmony-Look-for-composition-node-and-connect-automatically-if-not-Use-selection
…-for-composition-node-and-connect-automatically-if-not-Use-selection' into enhancement/AY-7307_Harmony-Look-for-composition-node-and-connect-automatically-if-not-Use-selection
@kalisp kalisp merged commit 466ba8c into develop Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants