Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix containers logic failing when id key is None #26

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 22, 2025

Changelog Description

Do not error on None value in id metadata if a scene object has that stored

Additional review information

Fixes error:

Traceback (most recent call last):
  File "C:\Users\jakub\AppData\Local\Ynput\AYON\dependency_packages\ayon_2412190933_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "C:\CODE\__YNPUT\ayon-core\client\ayon_core\plugins\publish\collect_scene_loaded_versions.py", line 39, in process
    containers = list(host.ls())
  File "C:\CODE\__YNPUT\ayon-harmony\client\ayon_harmony\api\pipeline.py", line 288, in ls
    if "container" not in data.get("id"):
TypeError: argument of type 'NoneType' is not iterable

Testing notes:

Not sure how to reproduce the 'invalid' object data however.

  1. Listing containers (and collecting publish instances) should continue to work

@BigRoy BigRoy added the type: bug Something isn't working label Jan 22, 2025
@BigRoy BigRoy requested a review from jakubjezek001 January 22, 2025 13:12
@BigRoy BigRoy self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant