Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consolidations on Hiero OTIO exporter #40

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Jan 15, 2025

Changelog Description

help resolve #29

  • We were loosing some accuracy on OTIO export for source range start_time, this was causing rounding issues with longest frame range.

Additional review information

Testing notes:

  1. Create a clip in Hiero with a long frame range (e.g. start_frame > 900,000 at 24.0 fps)
  2. Drag and drop on a 23.976 sequence while preserving clip duration
  3. Trim clip to specific frame input output
  4. Export sequence to OTIO and ensure source range of the clip match input frame when rescaled back to 24.0 fps

@robin-ynput robin-ynput self-assigned this Jan 15, 2025
@robin-ynput robin-ynput added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels Jan 15, 2025
@robin-ynput robin-ynput marked this pull request as ready for review January 22, 2025 20:42
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, lets merge

@jakubjezek001
Copy link
Member

@robin-ynput shouldn't we similar change also in Resolve?

@robin-ynput
Copy link
Contributor Author

robin-ynput commented Jan 27, 2025

@robin-ynput shouldn't we similar change also in Resolve?

Actually we do not, I triple checked this morning, it really dependsof the DCC "source_in" value returned by the API:

  • Flame and Hiero makes it based on the input media fps, hence the fix to keep it as accurate as possible during the conform.
  • Resolve returns it based on the input track fps, so already correct

@robin-ynput robin-ynput merged commit e9ae2db into develop Jan 27, 2025
1 check passed
@robin-ynput robin-ynput deleted the bugfix/29_fix_retime_computation branch January 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back publishing of clip retimes
2 participants