generated from ynput/ayon-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronisation issues #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Improve readability and avoid conflicts with Ayon attributes.
jakubjezek001
added
type: feature
Adding something new and exciting to the product
type: bug
Something isn't working
and removed
type: feature
Adding something new and exciting to the product
labels
Apr 24, 2024
…ity creation. Add logging for errors and warnings.
fabiaserra
reviewed
Apr 26, 2024
…t and tags. Improve code readability.
…otgridHub. Refactor attribute types assignment. Improve entity creation based on Shotgrid events, considering asset type and parent entity type for better accuracy.
…r match_shotgrid_hierarchy_in_ayon for efficiency, add debug logs. Create or find AssetCategory in AYON based on ShotGrid entity. Fix create_sg_entities_in_ay function signature and add missing code block in get_asset_category function.
Improve error handling for entity creation and commit_changes.
iLLiCiTiT
reviewed
May 2, 2024
services/shotgrid_common/ayon_shotgrid_hub/update_from_shotgrid.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
May 2, 2024
services/shotgrid_common/ayon_shotgrid_hub/update_from_shotgrid.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
May 2, 2024
services/shotgrid_common/ayon_shotgrid_hub/update_from_shotgrid.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
May 2, 2024
iLLiCiTiT
reviewed
May 2, 2024
iLLiCiTiT
reviewed
May 2, 2024
…d.py Co-authored-by: Jakub Trllo <[email protected]>
…d.py Co-authored-by: Jakub Trllo <[email protected]>
…d.py Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
- Added a check to create Ayon entity if missing ID - Improved logging messages for clarity
…-shotgrid into bugfix/services_fixes
Adjust how entities are fetched to avoid duplicate entries. Introduce a dictionary structure for storing entities and iterate through its values instead of directly processing the list returned by the API call.
…sing logic in Shotgrid-related services. Improve error handling and sync status updates.
fabiaserra
reviewed
May 6, 2024
fabiaserra
reviewed
May 6, 2024
fabiaserra
reviewed
May 6, 2024
services/shotgrid_common/ayon_shotgrid_hub/update_from_shotgrid.py
Outdated
Show resolved
Hide resolved
in AyonShotgridHub and remove default assignment in update_from_shotgrid.py. Add support for custom attribute types.
iLLiCiTiT
approved these changes
May 7, 2024
jakubjezek001
requested review from
64qam,
iLLiCiTiT and
fabiaserra
and removed request for
fabiaserra
May 7, 2024 09:22
64qam
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this PR had been created for simple fix of following traceback, but during the debugging more issues were found and were also included within the scope of this PR.
Original Traceback:
Other issues:
.get("sg_asset_type")
needed to be done on sg_ay_dict["data"], not on sg_ay_dictself.custom_attribs_types
fixed