Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added descriptions for libraries settings. #12

Closed
wants to merge 5 commits into from

Conversation

LiborBatek
Copy link
Member

@LiborBatek LiborBatek commented Oct 21, 2024

Added descriptions for addon's setting for better clarity and fixed small issue in the info text for OIIO category.

Resolves https://github.com/ynput/ayon-third-party/issues/11

Testing notes:

  1. Build addon package and upload to the server
  2. Check addon's settings categories and added descriptions if correct.

Copy link

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are too verbose and not needed descriptions.

To me just "Configure FFMPEG" and "Configure OIIO" could suffice - but the label of the section already clarifies what it's about. I'm not too bothered with adding it - but it does feel more cluttered to me.

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Oct 21, 2024
@LiborBatek
Copy link
Member Author

LiborBatek commented Oct 21, 2024

I have just started to add those descriptions going addon by addon (from top to bottom) as I like the tips really.

I get your point but the more info the better imho. Maybe its clear to you what fffmpeg is for and OIIO but it actually helped me to understand those a bit more (by searching for the definition online)...now it makes it more clear to me personally.

...speaking of cluttering the UI its more a matter of how its shown then the actual wording I have also seen much longer and clipped descriptions accross AYON and settings....

I have to admit, I would like to have those always as hoover over tips much more than these header ones tho. But thats something out of my capabalities...

@m-u-r-p-h-y any opinion on this?

server/settings.py Outdated Show resolved Hide resolved
server/settings.py Outdated Show resolved Hide resolved
@iLLiCiTiT
Copy link
Member

(There are no changes in the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants