Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Download directory contains platform name #20

Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Platform name is part of download directory so shared folder can be used on any platform.

Additional review information

When addons are stored to shared directory for multiple platforms, there won't happen clashes for different platforms.

Testing notes:

  1. Remove all third party addon versions from %LOCALAPPDATA%\Ynput\AYON\addons\.
  2. Create package with this PR, upload to server and use in bundle.
  3. Start AYON launcher.
  4. OIIO and ffmpeg executables are downloaded into platform specific subfolder.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Dec 11, 2024
@iLLiCiTiT iLLiCiTiT self-assigned this Dec 11, 2024
@iLLiCiTiT iLLiCiTiT merged commit 6ecb066 into develop Dec 11, 2024
4 of 5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/download-executables-to-platform-subdir branch December 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant