Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed GRPs from the app groups in the PreLaunchHook to avoid trying… #38

Merged
merged 1 commit into from
Sep 3, 2024
Merged

removed GRPs from the app groups in the PreLaunchHook to avoid trying… #38

merged 1 commit into from
Sep 3, 2024

Conversation

Lypsolon
Copy link
Collaborator

@Lypsolon Lypsolon commented Sep 3, 2024 •
edited
Loading

… to setup a resolver for an app we dont yet suport.

Changelog Description

this PR Removes the Prelaunch Trigger's for software packages that we dont have Resolvers for.

Additional info

Testing notes:

  1. Clone the Repo Switch to the Branch create a Package upload to server.
  2. open one of the suported apps and load an Ayon Uri (you can get this by selecting a represenation for a Published Product (needs to be USD) and then copy the Ayon:// uri)
  3. now open an app not in the list and see if it starts

@lyon040502003
removed GRPs from the app groups in the PreLaunchHook to avoid trying…
60c7e0c 
… to setup a resolver for an app we dont yet suport.
@Lypsolon Lypsolon marked this pull request as ready for review September 3, 2024 12:51
@Lypsolon Lypsolon mentioned this pull request Sep 3, 2024
Closed
7 tasks
@Lypsolon Lypsolon self-assigned this Sep 3, 2024
@Lypsolon Lypsolon requested review from BigRoy and antirotor September 3, 2024 12:53
BigRoy
BigRoy approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those are not on LakeFS so good to remove for now 👍

@BigRoy BigRoy merged commit 223bb6b into develop Sep 3, 2024
1 check passed
@Lypsolon Lypsolon deleted the 34A/remove_app_GRPs_that_dont_have_resolver_on_LakeFs branch September 12, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@Lypsolon Lypsolon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lypsolon @BigRoy @lyon040502003