Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Pinning file: Do not error on bad escape in regex pattern #64

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 3, 2024

Changelog Description

Do not error on bad escape in regex pattern

Additional info

Fixes #63

Testing notes:

  1. Configure project roots: XXX (to be defined!)
  2. Run a simple Maya USD publish from Maya (e.g. publish a cube)

@BigRoy BigRoy added the type: bug Something isn't working label Oct 3, 2024
@BigRoy BigRoy requested review from antirotor and Lypsolon October 3, 2024 20:02
@BigRoy BigRoy self-assigned this Oct 3, 2024
@BigRoy BigRoy marked this pull request as draft October 3, 2024 20:03
@BigRoy BigRoy marked this pull request as ready for review October 3, 2024 20:34
Copy link
Collaborator

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work.
i tested it via testing notes but the testing notes do not state any expectations. so i can only tell you that its not throwing an error.

i know we used to have this re escape in there a while ago but some one flagged it and so i removed it (not sure why that was).

@BigRoy
Copy link
Collaborator Author

BigRoy commented Oct 4, 2024

Thanks - I'll merge but open the remaining notes as issue because I'm sure the rootless path generation does not work.

@BigRoy BigRoy merged commit d0ded5f into develop Oct 4, 2024
1 check passed
@Lypsolon
Copy link
Collaborator

Lypsolon commented Oct 4, 2024

Thanks - I'll merge but open the remaining notes as issue because I'm sure the rootless path generation does not work.

yeah we need to "normalize" the input from ayon server as the string in there can be about anything.
good for us is that the usd returns will be the same every time.
so we just need to normalize the input to the Usd standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate data into USD pinning file error - _pinning_file_generation_funcs.py
2 participants