Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: llm bridge server communicates with zipper in memory way #996

Merged
merged 8 commits into from
Jan 26, 2025

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Jan 21, 2025

Description

  1. Implement frame.Listener using a golang channel.
  2. Zipper supports managing multiple frame.Listener instances.
  3. The LLM bridge server communicates with Zipper using the golang channel implementation of frame.Listener.

@woorui woorui requested a review from venjiang as a code owner January 21, 2025 15:42
@woorui woorui self-assigned this Jan 21, 2025
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 2:34am

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 47.50000% with 126 lines in your changes missing coverage. Please review.

Project coverage is 46.57%. Comparing base (6152a12) to head (eaee3e9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/bridge/ai/reducer.go 0.00% 75 Missing ⚠️
pkg/listener/mem/mem.go 83.01% 16 Missing and 2 partials ⚠️
cli/serve.go 0.00% 12 Missing ⚠️
pkg/bridge/ai/api_server.go 0.00% 8 Missing ⚠️
core/server_options.go 0.00% 4 Missing ⚠️
options.go 0.00% 4 Missing ⚠️
core/server.go 88.00% 3 Missing ⚠️
pkg/bridge/ai/service.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
- Coverage   46.89%   46.57%   -0.33%     
==========================================
  Files          97       99       +2     
  Lines        6721     6916     +195     
==========================================
+ Hits         3152     3221      +69     
- Misses       3370     3497     +127     
+ Partials      199      198       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@fanweixiao fanweixiao merged commit 2fe44be into master Jan 26, 2025
5 of 6 checks passed
@fanweixiao fanweixiao deleted the feat/chan-reducer branch January 26, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants