-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init node application #997
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 46.89% 46.47% -0.43%
==========================================
Files 97 100 +3
Lines 6721 7094 +373
==========================================
+ Hits 3152 3297 +145
- Misses 3370 3597 +227
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. |
@@ -16,6 +16,9 @@ var ( | |||
|
|||
// Serverless defines the interface for serverless | |||
type Serverless interface { | |||
// Setup sets up the serverless | |||
Setup(opts *Options) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between Setup(opts *Options) error
and Init(opts *Options) error
?
Should these two function be merged ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup
is used to configure the application environment and Init
is used to build
"github.com/yomorun/yomo/serverless/mock" | ||
) | ||
|
||
func TestHandler(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal _test.go
file works well, but the llm _test.go
doesn't work. Should we merge pull request #986 first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a pr here #998
@@ -70,13 +91,13 @@ var initCmd = &cobra.Command{ | |||
|
|||
log.SuccessStatusEvent(os.Stdout, "Congratulations! You have initialized the stream function successfully.") | |||
log.InfoStatusEvent(os.Stdout, "You can enjoy the YoMo Stream Function via the command: ") | |||
log.InfoStatusEvent(os.Stdout, "\tStep 1: cd %s && yomo build", name) | |||
log.InfoStatusEvent(os.Stdout, "\tStep 2: yomo run sfn.yomo") | |||
log.InfoStatusEvent(os.Stdout, "\tcd %s && yomo run", name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the yomo build
command be deprecated? Migrate the wasi
flag to yomo run
command..
1. Add `mock.NewArgumentsContext()` for testing llm function. 2. Add `WriteRecord.LLMResult` for retrieving llm function written data.
Description
The CLI adds the initializing node application as follows: