-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consider ingress and egress rules for networkpolicies #310
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 42.01% 42.39% +0.38%
==========================================
Files 61 61
Lines 3175 3236 +61
==========================================
+ Hits 1334 1372 +38
- Misses 1633 1644 +11
- Partials 208 220 +12 ☔ View full report in Codecov by Sentry. |
ca7c6b8
to
a55a8d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Some minor comments
@tthvo Sorry for the late review. |
Signed-off-by: Thuan Vo <[email protected]>
All good! I addressed the reviews in the latest commit :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Thanks!
What this PR does / why we need it?
This PR added consideration for discovering second-level unused NetworkPolicies with matching
.spec.podSelector
, but unmatched pods in Ingress/Egress rules.See #296 (comment)
PR Checklist
GitHub Issue
Solves #312
Notes for your reviewers
Rules with
ipBlock
is considered "used" here.