-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add filters to replicasets #324
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 41.77% 42.01% +0.24%
==========================================
Files 61 61
Lines 3179 3175 -4
==========================================
+ Hits 1328 1334 +6
+ Misses 1637 1633 -4
+ Partials 214 208 -6 ☔ View full report in Codecov by Sentry. |
Following a quick $ grep -rn 'if pass, _ := filter.Run' pkg/kor/
pkg/kor/clusterroles.go:47: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/clusterroles.go:64: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/finalizers.go:50: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/ingresses.go:39: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/replicaset.go:25: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/roles.go:30: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/services.go:34: if pass, _ := filter.Run(filterOpts); pass {
pkg/kor/statefulsets.go:25: if pass, _ := filter.Run(filterOpts); pass {
|
Good catch. I'll take care of all the references |
Removed the filter from areas in the code that are not referring to the actual resource. |
What this PR does / why we need it?
This adds the filters to replicasets
PR Checklist
GitHub Issue
Closes #318