Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user can't list return empty #360

Merged
merged 1 commit into from
Sep 18, 2024
Merged

When user can't list return empty #360

merged 1 commit into from
Sep 18, 2024

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Sep 17, 2024

What this PR does / why we need it?

When user can't list namespaces return empty instead of exiting

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

When user can't list return empty instead of exiting
@yonahd
Copy link
Owner Author

yonahd commented Sep 17, 2024

@hagay3 Is this good enough?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.43%. Comparing base (0e398dd) to head (d7bd103).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/filters/options.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files          61       61           
  Lines        3241     3241           
=======================================
  Hits         1440     1440           
  Misses       1574     1574           
  Partials      227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit 3d63b69 into main Sep 18, 2024
1 check passed
@yonahd yonahd deleted the yonahd-patch-1 branch September 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants