Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR changes the behavior of how
kor
maps unused PDBs.Currently, it validates the PDB label selector against Deployments/StatefulSets direct metadata labels, while it should validate the template labels, as PDBs select pods and through
.metadata.ownerReferences
field finds the respective workload controllers and not the other way around.For example, the following Deployment is valid, but
kor
will map it as unused, as.metadata.labels
field is not matched, even if the template labels match:In addition, added support for empty selectors & arbitrary pods.
PR Checklist
GitHub Issue
Closes #364
Notes for your reviewers
Based the feature on the official PDB docs.