-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ephemeral pvcs #403
Fix/ephemeral pvcs #403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 43.43% 43.72% +0.29%
==========================================
Files 63 63
Lines 4043 4064 +21
==========================================
+ Hits 1756 1777 +21
Misses 2039 2039
Partials 248 248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Thanks!
@yonahd Thank you for accepting the MR. Again, we'd love to have this fixed in our deployment ASAP, so do you have any estimate about next release? |
I'll try to create a new release early next week |
Hi @nemcikjan |
I merged the file so you can now open a pr to edit this file https://github.com/yonahd/kor/blob/main/ADOPTERS.md |
What this PR does / why we need it?
Fixes reporting PVC created as ephemeral to be reported
PR Checklist
GitHub Issue
Closes #402
Notes for your reviewers