Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ephemeral pvcs #403

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Fix/ephemeral pvcs #403

merged 6 commits into from
Jan 29, 2025

Conversation

nemcikjan
Copy link
Contributor

@nemcikjan nemcikjan commented Jan 24, 2025

What this PR does / why we need it?

Fixes reporting PVC created as ephemeral to be reported

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

GitHub Issue

Closes #402

Notes for your reviewers

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.72%. Comparing base (018acb5) to head (ac3c255).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   43.43%   43.72%   +0.29%     
==========================================
  Files          63       63              
  Lines        4043     4064      +21     
==========================================
+ Hits         1756     1777      +21     
  Misses       2039     2039              
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Thanks!

@yonahd yonahd merged commit afe957b into yonahd:main Jan 29, 2025
1 check passed
@nemcikjan nemcikjan deleted the fix/ephemeral-pvcs branch January 30, 2025 06:58
@nemcikjan
Copy link
Contributor Author

@yonahd Thank you for accepting the MR. Again, we'd love to have this fixed in our deployment ASAP, so do you have any estimate about next release?

@yonahd
Copy link
Owner

yonahd commented Jan 30, 2025

I'll try to create a new release early next week

@yonahd
Copy link
Owner

yonahd commented Feb 2, 2025

Hi @nemcikjan
I released a new version.
Any chance we can add you or your company to here as adopters?
#266

@nemcikjan
Copy link
Contributor Author

@yonahd sure thing. Should I contribute directly to #266, or will you do it?

@yonahd
Copy link
Owner

yonahd commented Feb 3, 2025

@yonahd sure thing. Should I contribute directly to #266, or will you do it?

I merged the file so you can now open a pr to edit this file https://github.com/yonahd/kor/blob/main/ADOPTERS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PVCs created as ephemeral volumes are being reported as unused
4 participants