Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on removing envoy #141

Closed
wants to merge 1 commit into from
Closed

Issue on removing envoy #141

wants to merge 1 commit into from

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Dec 20, 2023

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 requested a review from hackerwins December 20, 2023 04:00
@7hong13 7hong13 self-assigned this Dec 20, 2023
@7hong13 7hong13 changed the title remove envoy and update docker-compose Issue on removing envoy Jan 12, 2024
@7hong13
Copy link
Contributor Author

7hong13 commented Jan 12, 2024

When modifying the docker-compose script to exclude Envoy, the server response for activateRequest does not return. I guess it's being blocked at some point.

However, it works well in the following script:

ervices:
  yorkie:
    image: 'krapi0314/yorkie:test'
    container_name: 'yorkie'
    command: ['server', '--enable-pprof']
    restart: always
    ports:
      - '8080:8080'
      - '8081:8081'

@hackerwins
Copy link
Member

@7hong13 Are there any related logs or error messages?

@hackerwins hackerwins removed their request for review January 16, 2024 05:31
@7hong13
Copy link
Contributor Author

7hong13 commented Jan 16, 2024

@7hong13 Are there any related logs or error messages?

@hackerwins
I can't provide the related logs since sending the activateClientRequest doesn't result in either an exception or a response from the server; instead, it just gets stuck at line 126."

val activateResponse = try {
service.activateClient(
activateClientRequest {
clientKey = options.key
},
projectBasedRequestHeader,
)
} catch (e: StatusException) {
YorkieLogger.e("Client.activate", e.stackTraceToString())
return@async false
}
_status.emit(Status.Activated(ActorID(activateResponse.clientId)))

@skhugh
Copy link
Contributor

skhugh commented Apr 12, 2024

I believe this is resolved and merged by #167

@7hong13
Copy link
Contributor Author

7hong13 commented Apr 12, 2024

Closing it since the issue has been resolved.

@7hong13 7hong13 closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants