Fix incorrect index returned when using posRangeToIndexRange #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhugh
reviewed
Jan 31, 2024
| @@ -1743,6 +1746,65 @@ class JsonTreeTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun test_returning_range_from_index_correctly_withint_document_events() { | |||
There was a problem hiding this comment.
Suggested change
| fun test_returning_range_from_index_correctly_withint_document_events() { | |
| fun test_returning_range_from_index_correctly_within_document_events() { |
skhugh
reviewed
Jan 31, 2024
| if (node.id.createdAt <= executedAt) break | ||
| updatedLeftSiblingNode = node | ||
| } | ||
| updatedLeftSiblingNode |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 79.62% 79.64% +0.02%
==========================================
Files 63 63
Lines 3853 3857 +4
Branches 603 604 +1
==========================================
+ Hits 3068 3072 +4
Misses 459 459
Partials 326 326 ☔ View full report in Codecov by Sentry. |
skhugh
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist