Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent garbage collection for multiple nodes in text and tree type #175

Merged
merged 1 commit into from
May 13, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented May 13, 2024

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the bug 🐞 Something isn't working label May 13, 2024
@7hong13 7hong13 requested review from hackerwins and skhugh May 13, 2024 01:36
@7hong13 7hong13 self-assigned this May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.13%. Comparing base (92039e2) to head (dd46237).

Files Patch % Lines
...c/main/kotlin/dev/yorkie/document/crdt/CrdtRoot.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   79.10%   79.13%   +0.02%     
==========================================
  Files          63       63              
  Lines        4025     4025              
  Branches      644      644              
==========================================
+ Hits         3184     3185       +1     
+ Misses        488      487       -1     
  Partials      353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 added this to the 0.4.19 milestone May 13, 2024
@7hong13 7hong13 merged commit 004cb20 into main May 13, 2024
5 of 6 checks passed
@7hong13 7hong13 deleted the gc branch May 13, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants