Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor presence event code in examples #614

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

chacha912
Copy link
Contributor

What this PR does / why we need it?

  • Use 'presence' event instead of 'my-presence' or 'others' when displaying online clients
  • Remove unnecessary code in quill example
  • Display remote cursors when client connects to document (quill, codemirror)
  • Modify selection color to be set by presence(codemirror)

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@chacha912 chacha912 requested a review from hackerwins August 13, 2023 14:43
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #614 (ec094a4) into main (53185d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          81       81           
  Lines        8205     8205           
  Branches      816      816           
=======================================
  Hits         7195     7195           
  Misses        700      700           
  Partials      310      310           

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chacha912 Thanks for your contribution.

Should we change the base to v0.4.5-example like in #590 so that it doesn't deploy to https://yorkie.dev/examples?

@chacha912
Copy link
Contributor Author

@hackerwins I modified the examples in the "public" folder, so I think we can merge to main.
If modifications are needed in the v0.4.5-example branch, I will add commits accordingly.

@hackerwins hackerwins merged commit 9ea05a4 into main Aug 14, 2023
@hackerwins hackerwins deleted the refactor-presence-event branch August 14, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants