Add DisableGC option to document #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently we have implemented multi-user undo/redo feature and added inverse operation for Text.edit. While implementing, we noticed that the inverse operation accessed the removed node by GC. To address this issue, we've added the disableGC option to skip GC temporarily.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 88.83% 88.88% +0.04%
==========================================
Files 80 80
Lines 8942 8958 +16
Branches 823 825 +2
==========================================
+ Hits 7944 7962 +18
+ Misses 689 688 -1
+ Partials 309 308 -1
☔ View full report in Codecov by Sentry. |
chacha912
approved these changes
Sep 15, 2023
hyemmie
pushed a commit
that referenced
this pull request
Sep 18, 2023
Recently we have implemented multi-user undo/redo feature and added inverse operation for Text.edit. While implementing, we noticed that the inverse operation accessed the removed node by GC. To address this issue, we've added the disableGC option to skip GC temporarily.
2 tasks
2 tasks
20 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Add DisableGC option to document
Recently we have implemented multi-user undo/redo feature and added
inverse operation for Text.edit. While implementing, we noticed that
the inverse operation accessed the removed node by GC. To address this
issue, we've added the disableGC option to skip GC temporarily.
Any background context you want to provide?
What are the relevant tickets?
Related to #635
Checklist