Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jekyll on github actions #674

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Disable jekyll on github actions #674

merged 2 commits into from
Oct 21, 2023

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Oct 21, 2023

What this PR does / why we need it?

Prevent examples from being built with Jekyll. Next.js-based examples can't load css and js assets when built with Jekyll.

Any background context you want to provide?

Relative PR: yorkie-team/yorkie-team.github.io#106

What are the relevant tickets?

Fixes #673

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx self-assigned this Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7baa69f) 67.89% compared to head (7eef768) 67.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   67.89%   67.83%   -0.06%     
==========================================
  Files          58       58              
  Lines        8734     8734              
  Branches      784      784              
==========================================
- Hits         5930     5925       -5     
- Misses       2546     2550       +4     
- Partials      258      259       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review October 21, 2023 11:35
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js example is broken on GitHub Pages
2 participants