Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit Next.js example style to the yorkie homepage #675

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Oct 21, 2023

What this PR does / why we need it?

It's hard to see the Next.js example in dark mode on the homepage.

image

This PR change the above screen to look like the one below.

image

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx self-assigned this Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3587d1) 67.89% compared to head (f311004) 67.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   67.89%   67.89%           
=======================================
  Files          58       58           
  Lines        8734     8734           
  Branches      784      784           
=======================================
  Hits         5930     5930           
  Misses       2546     2546           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins self-requested a review October 21, 2023 13:22
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit cd0e102 into yorkie-team:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants