Prevent empty ops are applied during undo/redo #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto undo-redo-object
…kie-js-sdk into undo-redo-object
…nto undo-redo-object
- Display undo/redo stack count - Prevent script errors when clicking the undo/redo buttons
- Remove duplication between Array.getPositionedAt and Element.getLastExecutedAt - Add more comments
`getByID` is a method used by the system. In the CRDT layer, it should still return the element even if it has been deleted.
chacha912
force-pushed
the
no-ops-undo
branch
from
25e1541 to
32b29fd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 67.94% 67.97% +0.02%
==========================================
Files 58 58
Lines 8783 8786 +3
Branches 795 795
==========================================
+ Hits 5968 5972 +4
Misses 2555 2555
+ Partials 260 259 -1 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Nov 22, 2023
hackerwins
changed the title
hackerwins
pushed a commit
that referenced
this pull request
Nov 23, 2023
This commit addresses the issue of client sequences being absent on the server. It accomplishes this by preventing the update of changeID.
hackerwins
pushed a commit
that referenced
this pull request
Nov 23, 2023
This commit addresses the issue of client sequences being absent on the server. It accomplishes this by preventing the update of changeID.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Handle cases where no operations have been applied during undo/redo.
This PR resolved the issue of missing client sequences on the server by preventing the update of changeID.
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist