New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript-examples): _.pull #310

Merged

stevemao merged 1 commit into you-dont-need:master from casaper:feat/typescript-examples

Jan 13, 2022

Contributor

casaper commented Apr 23, 2021

A start for converting examples to typescript.

Starting to full fill my own created issue #309.

coveralls commented Apr 23, 2021

Coverage remained the same at 100.0% when pulling 2eb34f5 on casaper:feat/typescript-examples into cd0c68e on you-dont-need:master.

1 similar comment

coveralls commented Apr 23, 2021

Coverage remained the same at 100.0% when pulling 2eb34f5 on casaper:feat/typescript-examples into cd0c68e on you-dont-need:master.

johtso commented Jul 2, 2021

Interestingly this is an example where the native alternative suggested is not equivalent.. lodash updates the array in-place.

stevemao reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Contributor Author

casaper commented Oct 18, 2021

Interestingly this ... lodash updates the array in-place.

I guess you're right. I do not introduce this difference here though, because the original example already has that «flaw».

IMHO it isn't really a flaw though, because being a side effect is one of the things I specifically dislike with lodash and many other classic js libs.

I think it might be good to point out that difference in the example though.

casaper force-pushed the feat/typescript-examples branch 3 times, most recently from 5287e75 to ba3a8e1 Compare

October 18, 2021 13:34

casaper marked this pull request as ready for review

October 18, 2021 13:35


          feat(typescript-examples): _.pull

149ee7c

casaper force-pushed the feat/typescript-examples branch from ba3a8e1 to 149ee7c Compare

October 18, 2021 13:37

casaper requested a review from stevemao

October 18, 2021 14:38

stevemao approved these changes

View reviewed changes

Member

stevemao left a comment

thanks

stevemao requested a review from a team

October 31, 2021 02:55

stevemao merged commit 5bddb71 into you-dont-need:master

kodiakhq bot referenced this pull request in cloudquery/plugin-sdk-javascript


          fix(deps): Update dependency eslint-plugin-you-dont-need-lodash-under…

f2aca02

…score to v6.13.0 (#84)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-plugin-you-dont-need-lodash-underscore](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore.git) ([source](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore)) | devDependencies | minor | [`6.12.0` -> `6.13.0`](https://renovatebot.com/diffs/npm/eslint-plugin-you-dont-need-lodash-underscore/6.12.0/6.13.0) |

---

### Release Notes

<details>
<summary>you-dont-need/You-Dont-Need-Lodash-Underscore (eslint-plugin-you-dont-need-lodash-underscore)</summary>

### [`v6.13.0`](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/releases/tag/v6.13.0)

[Compare Source](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/compare/v6.12.0...v6.13.0)

#### What's Changed

-   Add \_.capitalize by [@&#8203;iandrewt](https://togithub.com/iandrewt) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/320](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/320)
-   Add \_.unionBy by [@&#8203;iandrewt](https://togithub.com/iandrewt) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/319](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/319)
-   Add rule for \_.defaults by [@&#8203;cupofjoakim](https://togithub.com/cupofjoakim) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/322](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/322)
-   Remove duplicate \_.uniq by [@&#8203;Semigradsky](https://togithub.com/Semigradsky) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/325](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/325)
-   adding \_.uniqWith by [@&#8203;JasonCubic](https://togithub.com/JasonCubic) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/323](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/323)
-   Fix \_.isString alternative by [@&#8203;Semigradsky](https://togithub.com/Semigradsky) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/324](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/324)
-   Add \_.isDate by [@&#8203;MarcosEllys](https://togithub.com/MarcosEllys) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/326](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/326)
-   Remove unnecessary falsey checks by [@&#8203;suspiciousfellow](https://togithub.com/suspiciousfellow) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/328](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/328)
-   Add \_.lowerFirst by [@&#8203;Semigradsky](https://togithub.com/Semigradsky) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/329](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/329)
-   Add more suggestions for \_.first by [@&#8203;twjasa](https://togithub.com/twjasa) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/332](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/332)
-   Add note to `isArrayBuffer` and add it to eslint plugin by [@&#8203;Semigradsky](https://togithub.com/Semigradsky) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/330](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/330)
-   feat(typescript-examples): \_.pull by [@&#8203;casaper](https://togithub.com/casaper) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/310](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/310)
-   feat: add lodash/fp support by [@&#8203;jpickwell](https://togithub.com/jpickwell) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/341](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/341)
-   Add Array.at(-1) which equals to \_.last by [@&#8203;kingyue737](https://togithub.com/kingyue737) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/343](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/343)
-   update collectionKeyBy so it works for objects by [@&#8203;ImTheTom](https://togithub.com/ImTheTom) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/345](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/345)
-   Fix: errorneous description for \_.isNull by [@&#8203;Koura](https://togithub.com/Koura) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/336](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/336)
-   Update README.md by [@&#8203;BtM909](https://togithub.com/BtM909) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/357](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/357)
-   Bump qs from 6.3.2 to 6.3.3 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/354](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/354)
-   Docs: remove david-dm.org badge from README by [@&#8203;SukkaW](https://togithub.com/SukkaW) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/348](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/348)
-   Bump minimatch from 3.0.4 to 3.1.2 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/358](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/358)
-   Fix \_first test by [@&#8203;AlexP11223](https://togithub.com/AlexP11223) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/352](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/352)
-   Update edge support in README.md by [@&#8203;gilly3](https://togithub.com/gilly3) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/360](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/360)
-   The debounce function does not work if 'immediate' is true by [@&#8203;ChenKun1997](https://togithub.com/ChenKun1997) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/362](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/362)
-   feat: add workflows PR & master by [@&#8203;Abdel-Monaam-Aouini](https://togithub.com/Abdel-Monaam-Aouini) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/359](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/359)
-   fix: add package-lock to run workflow by [@&#8203;Abdel-Monaam-Aouini](https://togithub.com/Abdel-Monaam-Aouini) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/364](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/364)
-   head, first & last rules by [@&#8203;Endremgs](https://togithub.com/Endremgs) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/373](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/373)
-   Update README.md by [@&#8203;TawalMc](https://togithub.com/TawalMc) in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/374](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/374)

#### New Contributors

-   [@&#8203;iandrewt](https://togithub.com/iandrewt) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/320](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/320)
-   [@&#8203;Semigradsky](https://togithub.com/Semigradsky) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/325](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/325)
-   [@&#8203;JasonCubic](https://togithub.com/JasonCubic) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/323](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/323)
-   [@&#8203;MarcosEllys](https://togithub.com/MarcosEllys) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/326](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/326)
-   [@&#8203;suspiciousfellow](https://togithub.com/suspiciousfellow) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/328](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/328)
-   [@&#8203;twjasa](https://togithub.com/twjasa) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/332](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/332)
-   [@&#8203;jpickwell](https://togithub.com/jpickwell) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/341](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/341)
-   [@&#8203;kingyue737](https://togithub.com/kingyue737) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/343](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/343)
-   [@&#8203;ImTheTom](https://togithub.com/ImTheTom) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/345](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/345)
-   [@&#8203;Koura](https://togithub.com/Koura) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/336](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/336)
-   [@&#8203;BtM909](https://togithub.com/BtM909) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/357](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/357)
-   [@&#8203;AlexP11223](https://togithub.com/AlexP11223) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/352](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/352)
-   [@&#8203;gilly3](https://togithub.com/gilly3) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/360](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/360)
-   [@&#8203;ChenKun1997](https://togithub.com/ChenKun1997) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/362](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/362)
-   [@&#8203;Abdel-Monaam-Aouini](https://togithub.com/Abdel-Monaam-Aouini) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/359](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/359)
-   [@&#8203;Endremgs](https://togithub.com/Endremgs) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/373](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/373)
-   [@&#8203;TawalMc](https://togithub.com/TawalMc) made their first contribution in [https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/374](https://togithub.com/you-dont-need/You-Dont-Need-Lodash-Underscore/pull/374)

**Full Changelog**: you-dont-need/You-Dont-Need-Lodash-Underscore@v6.12.0...v6.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet