Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask the changing temperature issue as reported in #2088. #3402

Merged
merged 12 commits into from
Feb 28, 2025
Merged

Mask the changing temperature issue as reported in #2088. #3402

merged 12 commits into from
Feb 28, 2025

Conversation

clifcox
Copy link
Contributor

@clifcox clifcox commented Feb 15, 2025 •
edited
Loading

Output of "show system" changes from:

! Unit            Temperature (Celsius)            Status
! ------------------------ ------------------------ ------------------------
! 1                        33                       OK

To:

! Unit            Temperature (Celsius)            Status
! ------------------------ ------------------------ ------------------------
! 1                        XXX                      OK
!

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Re-Closes issue #2088 ;-)

@clifcox
Mask the changing temperature issue as reported in ytti#2088. Output …
4cb3197 
…of "show system" changes from:

! Unit            Temperature (Celsius)            Status
! ------------------------ ------------------------ ------------------------
! 1                        33                       OK

To:

! Unit            Temperature (Celsius)            Status
! ------------------------ ------------------------ ------------------------
! 1                        XXX                      OK
!
@clifcox
Update to my solution for mask_changing_temperatures
9c354a0 
I noticed that different powerconnect series like 3400, 3500, 6200 would have diferent widths of temperature tables, and
wanted to format the output better. Also if someone decides to include the temp tables in a stacked switch setup, you
could, and only generate config changes when the temp evaluation went from OK to Fail.
@clifcox
Change the mask back from ZZZ to XXX. ;-)
653d08f
@clifcox
Update CHANGELOG.md
f45c925 
powerconnect: Mask the changing temperature issue for non-staced switches. Fixes ytti#2088 (@clifcox)
@clifcox
Update CHANGELOG.md
69b75d0 
Fix typo
@clifcox
Updates suggested by rubocop. No symantic changes.
8fc346e
@clifcox
Copy link
Contributor Author

clifcox commented Feb 19, 2025

Fixed.

@robertcheramy
Copy link
Collaborator

Could you replace {3,} with +? This should solve the CodeQL warning.

@clifcox
Copy link
Contributor Author

clifcox commented Feb 20, 2025

I'm new to CodeQL, is it complaining about the (.*) now? I can't tell. :-)

@robertcheramy
Copy link
Collaborator

I've found the problem - using / +.*/ makes the regexp problematic, as . could also match .

@robertcheramy robertcheramy merged commit 03032fc into ytti:master Feb 28, 2025
7 checks passed
@clifcox clifcox deleted the 2088-mask_changing_temperatures branch February 28, 2025 20:20
@clifcox
Copy link
Contributor Author

clifcox commented Feb 28, 2025

That makes more sense now.

Thanks, :-)
Clif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clifcox @robertcheramy