Skip to content

Commit

Permalink
fix: update binary naming in installation scripts to remove 'v' prefix
Browse files Browse the repository at this point in the history
- Modified the installation scripts for both PowerShell and shell to remove the 'v' prefix from the latest release tag when constructing binary names.
- This change ensures consistency in binary naming and improves compatibility with the expected format for asset retrieval.
  • Loading branch information
yuaotian committed Dec 30, 2024
1 parent d32476d commit 8f52929
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ function Install-CursorModifier {

# Look for Windows binary with our architecture
$possibleNames = @(
"cursor-id-modifier_$($latestRelease.tag_name)_windows_x86_64.exe",
"cursor-id-modifier_$($latestRelease.tag_name)_windows_$($arch).exe",
"cursor-id-modifier_$($latestRelease.tag_name.TrimStart('v'))_windows_x86_64.exe",
"cursor-id-modifier_$($latestRelease.tag_name.TrimStart('v'))_windows_$($arch).exe",
"cursor-id-modifier_windows_$($arch).exe"
)

Expand Down
5 changes: 4 additions & 1 deletion scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,11 @@ main() {
echo -e "${BLUE}Fetching latest release information...${NC}"
LATEST_URL="https://api.github.com/repos/yuaotian/go-cursor-help/releases/latest"

# Get latest version and remove 'v' prefix
VERSION=$(curl -s "$LATEST_URL" | grep "tag_name" | cut -d'"' -f4 | sed 's/^v//')

# Construct binary name
BINARY_NAME="cursor-id-modifier_${latestRelease.tag_name}_${OS}_${ARCH}"
BINARY_NAME="cursor-id-modifier_${VERSION}_${OS}_${ARCH}"
echo -e "${BLUE}Looking for asset: $BINARY_NAME${NC}"

# Get download URL directly
Expand Down

0 comments on commit 8f52929

Please sign in to comment.