Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.3 support - add com.intellij.modules.json dependency #456

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

2024.3 support - add com.intellij.modules.json dependency #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ plugins {

intellij {
//Bundled plugin dependencies
plugins.set(listOf("yaml", "com.intellij.java", "org.jetbrains.plugins.yaml"))
// "com.intellij.modules.json" to be added when minimum required version is at least 2024.3
plugins.set(listOf("com.intellij.java", "org.jetbrains.plugins.yaml"))
pluginName.set("intellij-swagger")
version.set("2022.3") // Recommended to use the lowest supported version to compile against
}
Expand Down
6 changes: 6 additions & 0 deletions src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
<name>Zalando OpenAPI Editor</name>
<vendor email="[email protected]" url="https://tech.zalando.com/">Zalando SE</vendor>

<!-- Module dependencies -->
<depends>com.intellij.modules.platform</depends>
<depends>com.intellij.modules.lang</depends>
<depends>com.intellij.modules.json</depends> <!-- Bundled plugin starting from 2024.3 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if the previous versions of IntellIj don't have this, will it still work with older versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, it has been a module and in 2024.3 it was migrated to a (bundled) plugin. So, older versions have it and the declaration for the dependency was just missing.
However, it's not clear if this will be enough, or if we need to also add a plugin dependency. The challenge there is that the json plugin is only available for 2024.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation. But how would we then find out? Just merging this PR and see what happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally yes. We can do a release to the beta channel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is then preventing us to move this PR from draft to ready for review?


<!-- Bundled plugin dependencies -->
<depends>com.intellij.java</depends>
<depends>org.jetbrains.plugins.yaml</depends>

<description><![CDATA[
Expand Down