Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gradle versions plugin due to dependabot integration #471

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

cberg-zalando
Copy link
Member

Based on the discussion in #468, we decided to remove the plugin as we use dependabot for dependency updates in this project.

@cberg-zalando cberg-zalando requested a review from a team as a code owner February 4, 2025 06:32
Copy link

invalid team ID

The team ID in your .zappr.yaml file does not appear to be valid. Please, fix
this before team ID checks will be added back into ComPR's specification check.

You can follow this guideline for help.

@cberg-zalando
Copy link
Member Author

Looks like GitHub's flow is changed and author's cannot approve their own PR's, which actually makes sense to some degree, @asaarilahti. I am not sure who we can ask for getting the missing approval.

@asaarilahti
Copy link
Contributor

Looks like GitHub's flow is changed and author's cannot approve their own PR's

The old 👍 should work. I agree this self-approval is bit weird.

@cberg-zalando
Copy link
Member Author

👍

@asaarilahti
Copy link
Contributor

The old 👍 should work. I agree this self-approval is bit weird.

Hmm, apparently not.

Maybe it requires the same setup as in internal repos. Could you perhaps check from opensource chat room?

@cberg-zalando
Copy link
Member Author

Let me try that…

@cberg-zalando cberg-zalando merged commit ae4f0a1 into master Feb 7, 2025
4 checks passed
@cberg-zalando cberg-zalando deleted the remove-versions-plugin branch February 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants