Add a test case on input contract validation #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushpalanka
force-pushed
the
input-contract
branch
from
7c90924 to
7316b8f
Compare
Pushpalanka
force-pushed
the
input-contract
branch
from
7316b8f to
7da400c
Compare
Pushpalanka
requested review from
mjungsbluth
and removed request for
mjungsbluth
|
👍 |
filters/openpolicyagent/opaauthorizerequest/opaauthorizerequest_test.go
Outdated
Show resolved
Hide resolved
Comment on lines
724
to
728
| for name, values := range ti.removeHeaders { | ||
| for _, value := range values { | ||
| req.Header.Add(name, value) //adding the headers to validate removal. | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems to be unused by the test cases. Lets remove all unused testcase fields and introduce them later along with testcases that utilize them.
Comment on lines
+729
to
+753
| for name, values := range ti.requestHeaders { | ||
| for _, value := range values { | ||
| req.Header.Add(name, value) | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we can simply assign here like req.Header = ti.requestHeaders
There was a problem hiding this comment.
Prefer to not do this as it internally initiated with default values—including the "User-Agent: Go-http-client/1.1" header leading to some hidden side effects.
filters/openpolicyagent/opaauthorizerequest/opaauthorizerequest_test.go
Outdated
Show resolved
Hide resolved
filters/openpolicyagent/opaauthorizerequest/opaauthorizerequest_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
Pushpalanka
force-pushed
the
input-contract
branch
from
c34d422 to
12e45e9
Compare
Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
Pushpalanka
force-pushed
the
input-contract
branch
from
12e45e9 to
f76b2e0
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm the included cases of envoy input format included in Skipper.
HTTP2 headers are not supported yet.
Also below items are not supported though available in the envoy input format.
input.attributes.request.http.protocol == "HTTP/1.1" input.attributes.destination.address.socketAddress.address == "10.25.95.68" input.attributes.destination.address.socketAddress.portValue == 8000 input.attributes.source.address.socketAddress.address == "10.25.95.69" input.attributes.source.address.socketAddress.portValue == 33772 input.attributes.request.http.headers[":authority"] == "example-app"