eskip: improve invalid predicate arguments error message #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add route id and predicate name to the error message. Signed-off-by: Alexander Yastrebov <[email protected]>
Comment on lines
+537
to
+542
| if err != nil { | ||
| return fmt.Errorf("invalid route %q: %w", proute.id, err) | ||
| } | ||
| } | ||
|
|
||
| return err | ||
| return nil |
|
👍 |
1 similar comment
|
👍 |
This was referenced Jan 15, 2025
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jan 23, 2025
* update main version * configure `-kubernetes-annotation-filters-append` and `-kubernetes-east-west-range-annotation-filters-append` (added by zalando/skipper#3376) Pull requests: * zalando/skipper#3371 * zalando/skipper#3368 * zalando/skipper#3369 * zalando/skipper#3370 * zalando/skipper#3372 * zalando/skipper#3373 * zalando/skipper#3374 * zalando/skipper#3375 * zalando/skipper#3380 * zalando/skipper#3376 * zalando/skipper#3381 * zalando/skipper#3379 * zalando/skipper#3378 See: * [changes](zalando/skipper@v0.21.247...v0.21.257) * #8791 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add route id and predicate name to the error message.