config: allow multiple -inline-routes value #3383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
multiple-inline-routes
branch
from
0013de4 to
7b9729c
Compare
Extend config.Config and skipper.Options to allow multiple sets of routes in eskip format for convenience. Fixes #3366 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
multiple-inline-routes
branch
from
7b9729c to
c5e3d20
Compare
| @@ -125,7 +125,7 @@ type Config struct { | |||
| EtcdPassword string `yaml:"etcd-password"` | |||
| RoutesFile string `yaml:"routes-file"` | |||
| RoutesURLs *listFlag `yaml:"routes-urls"` | |||
| InlineRoutes string `yaml:"inline-routes"` | |||
| InlineRoutes multiFlag `yaml:"inline-routes"` | |||
There was a problem hiding this comment.
This is a breaking change for yaml-based configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend config.Config and skipper.Options to allow multiple sets of routes in eskip format for convenience.
Fixes #3366