[PDE-5716] feat(cli): Require --overwrite-partner-changes flag when a zapier push from staff could impact partner changes
#960
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnegron
commented
Jan 29, 2025
| }, | ||
| extraHeaders: headers, | ||
| }, | ||
| true, |
There was a problem hiding this comment.
This true adds rawError = True so we can catch a response as err and can do err.status.
kola-er
reviewed
Jan 30, 2025
| 'overwrite-partner-changes': Flags.boolean({ | ||
| description: | ||
| '(Internal Use Only) Allows Zapier Staff to push changes to integrations in certain situations.', | ||
| hidden: true, |
kola-er
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #942, where we added a
--forceoption toenv:setandenv:unset.In this MR, we add a
--overwrite-partner-changesflag to force azapier pushto skip a new check when the user is a Zapier staff and the latest integration version contains partner-pushed code ("clobbering" protection).